Skip to content

Conversation

@CharlesDuboisSAP
Copy link
Contributor

@CharlesDuboisSAP CharlesDuboisSAP commented Apr 2, 2025

Context

AI/ai-sdk-java-backlog#222.

The prompt registry client is present but not tested, documented and published

documentation

Feature scope:

  • Add e2e tests
  • Published
  • Drive-by moved AI Core services to their own folder

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

@CharlesDuboisSAP CharlesDuboisSAP self-assigned this Apr 2, 2025
@CharlesDuboisSAP CharlesDuboisSAP added the please-review Request to review a pull-request label Apr 2, 2025
@CharlesDuboisSAP CharlesDuboisSAP changed the title feat: [Prompt Registry] Release module feat: [PromptRegistry] Release module Apr 2, 2025
<groupId>com.sap.ai.sdk</groupId>
<artifactId>sdk-parent</artifactId>
<version>1.6.0-SNAPSHOT</version>
<relativePath>../../pom.xml</relativePath>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by change for all AI Core services
image

<module>orchestration</module>
<module>document-grounding</module>
<module>core-services/document-grounding</module>
<module>core-services/prompt-registry</module>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Released prompt-registry

Copy link
Member

@Jonas-Isr Jonas-Isr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CharlesDuboisSAP CharlesDuboisSAP merged commit 544a067 into main Apr 3, 2025
6 checks passed
@CharlesDuboisSAP CharlesDuboisSAP deleted the prompt-registry branch April 3, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

please-review Request to review a pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants